Transport API #963
Merged
Transport API #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename *Dispatch classes to *Transport and added aliases
|
Hmmm, not sure what's going on here, all checks are "cancelled" and there's no log at all so I guess I'll try again later 🤷♂️ |
tomchristie
reviewed
May 20, 2020
|
Looks like a linter failure on import sorting... https://github.com/encode/httpx/pull/963/checks?check_run_id=693477366 |
JayH5
reviewed
May 20, 2020
JayH5
reviewed
May 20, 2020
florimondmanca
previously requested changes
May 21, 2020
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
Probably best to change the docs now, there's quite a few code snippets using |
tomchristie
reviewed
May 21, 2020
tomchristie
approved these changes
May 21, 2020
|
Great, once everyone's happy let's get this in as it is. Couple of follow ups I can think of, which I'll open individual issues for. |
Closed
|
Thanks all! 🎉 |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #768
I did somedispatch > transportrenaming but did not rename the_dispatchpackage and the*Dispatchclasses in it. I considered renaming the package to_transportsand all classes to*Transportwith*Dispatchaliases but thought it might be better to check first.Edit: Pipelines failed for some reason so I went for it while I gave GH actions some time to sort themselves out.