Include missing keepalive_expiry configuration #1005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs encode/httpcore#44
In 12.x we used to default the keepalive_expiry to 5.0 to mitigate asyncio's flaky behaviour for checking the aliveness of the TCP connection. https://github.com/encode/httpx/blob/0.12.1/httpx/_dispatch/connection_pool.py#L89
We failed to continue to do so in 13.x when we switched to
httpcore
. This change reverts that.