-
-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp proxies documentation #1123
Conversation
👀 Wow, this is fantastic! Since it ties in here, what are your thoughts on #1105? I think the docs read even more nicely if we're starting with We could already move to using that style in these docs, since it works like that already, we just happen to be special casing the plain |
Other thoughts...
|
In any case, going to approve this, since it's fantastic, and we can move on whichever of those items you think is valid (or not). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yas, love it! ✨
Absolutely agree yes, the progression from |
Promted by #927 (comment)
Our current proxies documentation is a bit lacking, and not necessarily nudging users to use the most simple solution whenever possible (i.e.
Client(proxies="http://...")
), so I dived my head into the world of web proxies and came up with this updated documentation, which outlines:Rendered preview: