Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate content=... and data=... parameters #1266

Merged
merged 4 commits into from
Sep 15, 2020
Merged

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Sep 7, 2020

Closes #1210

Adds support for eg. httpx.post(..., content=<bytes|byte iterator|byte aiterator>) for uploading raw content.
This is distinct from httpx.post(..., data=<dict>) for sending form data.

See also #1265.

@tomchristie tomchristie added the user-experience Ensuring that users have a good experience using the library label Sep 7, 2020
@tomchristie tomchristie added this to the v1.0 milestone Sep 10, 2020
@tomchristie
Copy link
Member Author

Particularly now that we have Response(content=...) I'd like us to press on with this one.

@tomchristie tomchristie merged commit feb404f into master Sep 15, 2020
@tomchristie tomchristie deleted the request-content branch September 15, 2020 12:36
@tomchristie tomchristie mentioned this pull request Sep 21, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-experience Ensuring that users have a good experience using the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate httpx.post(content=...) from httpx(data=...)?
1 participant