Refactoring of models api - 2 #1289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed URL.full_path to .raw_path (now its returns no-unquoted bytes) Made URL.userinfo return bytes instead of str Made URL.query return bytes instead of str
|
@cdeler - Note that I've already got some work towards this in https://github.com/encode/httpx/pull/1285/files |
|
@tomchristie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second part of #1275 changes (previous was merged)
What was done:
URL.full_pathto.raw_path(now its returns no-unquoted bytes)URL.userinforeturn bytes instead of strURL.queryreturn bytes instead of str