Fix docs syntax highlighting #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
added
bug
euri10
approved these changes
Feb 28, 2021
sthagen
added a commit
to sthagen/encode-httpx
that referenced
this pull request
Mar 1, 2021
Fix docs syntax highlighting (encode#1489)
This was referenced Mar 15, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now our docs is broken wrt syntax highlighting: code blocks render as "plain text".
Turns out a fair bit has changed in the world
mkdocs-materialand Markdown extensions since we last deployed docs. MkDocs-Material went from 5.* to 7., and circa 6.2. it seems to have migrated fromcodehiliteto Highlight as their primary syntax highlighting engine. As a result the CSS class changed from.codehiliteto.highlight— hence the fix in this PR to get code blocks highlighting back. :-)