Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.25.2 #2957

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Version 0.25.2 #2957

merged 2 commits into from
Nov 24, 2023

Conversation

karpetrosyan
Copy link
Member

Changelog

0.25.2

Added

@tomchristie
Copy link
Member

Great. We could also mention that we're enforcing httpcore>=1.0 now, but I don't think it matters too much either way.

Happy to help get this released if needed.

@karpetrosyan
Copy link
Member Author

We can also consider adding #2879 to this release if you wish.

I think it would be better to start migration to the new proxy API as soon as possible.

@tomchristie
Copy link
Member

I'd also appreciate get that in soon, tho it's an API change and needs to be part of a major release.

@karpetrosyan
Copy link
Member Author

Do we really need a major release to add a new public API? (when we do support the previous one)

SEMVER says

  • MAJOR version when you make incompatible API changes
  • MINOR version when you add functionality in a backward compatible manner
  • PATCH version when you make backward compatible bug fixes

I thought we would release a major version if the previous API was deleted.

@karpetrosyan
Copy link
Member Author

Also this:

https://semver.org/#spec-item-7

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

and this

https://semver.org/#spec-item-7

Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backward compatible functionality is introduced to the public API. It MUST be incremented if any public API functionality is marked as deprecated. It MAY be incremented if substantial new functionality or improvements are introduced within the private code. It MAY include patch level changes. Patch version MUST be reset to 0 when minor version is incremented.

@tomchristie
Copy link
Member

It's an (somewhat) incompatible API change, since it introduces a deprecation warning with the current usage.

@karpetrosyan
Copy link
Member Author

Deprecation cases are mentioned here, or am I missing something?

Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backward compatible functionality is introduced to the public API. It MUST be incremented if any public API functionality is marked as deprecated. It MAY be incremented if substantial new functionality or improvements are introduced within the private code. It MAY include patch level changes. Patch version MUST be reset to 0 when minor version is incremented.

@tomchristie
Copy link
Member

We've got a few type annotations and we're updating our dependancies. Let's roll a minor release for that.

#2879 introduces an API change and shouldn't be included. The rest is just noise.

@karpetrosyan
Copy link
Member Author

Should I draft a new release? Or you want to do it yourself.

@tomchristie
Copy link
Member

I don't mind. Do team members have the correct permissions for the "draft a new release" control on this page?

@karpetrosyan
Copy link
Member Author

Yes, it seems I have enough permissions to do that.
Here is the release draft: https://github.com/encode/httpx/releases/tag/untagged-3a61a71d71d75f055218

I have set the release date to tomorrow.

CHANGELOG.md Outdated Show resolved Hide resolved
@karpetrosyan
Copy link
Member Author

Are you fine with releasing this @tomchristie? It seems I can't run the workflow for release.

@tomchristie
Copy link
Member

Our process (for visibility)...

  • We merge the release PR.
  • We "publish release" on the release draft.
  • We approve the release workflow. (requires @encode/operations permissions.)

@karpetrosyan karpetrosyan merged commit cc206cf into encode:master Nov 24, 2023
5 checks passed
@karpetrosyan
Copy link
Member Author

Here is the 0.25.2 release: https://github.com/encode/httpx/releases/tag/0.25.2

Now it's time for @encode/operations to double-check and run the workflow.

@tomchristie
Copy link
Member

O hai... https://pypi.org/project/httpx/0.25.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants