-
-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.25.2 #2957
Version 0.25.2 #2957
Conversation
Great. We could also mention that we're enforcing Happy to help get this released if needed. |
We can also consider adding #2879 to this release if you wish. I think it would be better to start migration to the new proxy API as soon as possible. |
I'd also appreciate get that in soon, tho it's an API change and needs to be part of a major release. |
Do we really need a major release to add a new public API? (when we do support the previous one) SEMVER says
I thought we would release a major version if the previous API was deleted. |
Also this: https://semver.org/#spec-item-7
and this https://semver.org/#spec-item-7
|
It's an (somewhat) incompatible API change, since it introduces a deprecation warning with the current usage. |
Deprecation cases are mentioned here, or am I missing something? Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backward compatible functionality is introduced to the public API. It MUST be incremented if any public API functionality is marked as deprecated. It MAY be incremented if substantial new functionality or improvements are introduced within the private code. It MAY include patch level changes. Patch version MUST be reset to 0 when minor version is incremented. |
We've got a few type annotations and we're updating our dependancies. Let's roll a minor release for that. #2879 introduces an API change and shouldn't be included. The rest is just noise. |
Should I draft a new release? Or you want to do it yourself. |
I don't mind. Do team members have the correct permissions for the "draft a new release" control on this page? |
Yes, it seems I have enough permissions to do that. I have set the release date to tomorrow. |
Are you fine with releasing this @tomchristie? It seems I can't run the workflow for release. |
Our process (for visibility)...
|
Here is the 0.25.2 release: https://github.com/encode/httpx/releases/tag/0.25.2 Now it's time for @encode/operations to double-check and run the workflow. |
Changelog
0.25.2
Added
__init__()
methods. (add missing type hints to __init__(...) #2938)