Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.26.0 #3009

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Version 0.26.0 #3009

merged 5 commits into from
Dec 20, 2023

Conversation

karpetrosyan
Copy link
Member

@karpetrosyan karpetrosyan commented Dec 18, 2023

Chanelog

Added

Deprecated

Fixed

@karpetrosyan
Copy link
Member Author

karpetrosyan commented Dec 19, 2023

@T-256
Copy link
Contributor

T-256 commented Dec 19, 2023

Don't forget #2990

@tomchristie
Copy link
Member

tomchristie commented Dec 19, 2023

Thanks @T-256 - apologies for missing the CHANGELOG.md entry on that.

I'd suggest either this...

Or this...

@karpetrosyan
Copy link
Member Author

Thanks @T-256

I think this one is better

Fix cases of double escaping of URL path components. Allow / as a safe character in the query portion. #2990.

@tomchristie
Copy link
Member

I think this one is better

Ok. Let's go with that.

@karpetrosyan
Copy link
Member Author

Should I schedule it for today?

@tomchristie
Copy link
Member

That would be fine, yep.
Thanks so much, @karpetrosyan. 😄

@karpetrosyan
Copy link
Member Author

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to make it clear the proxies=... does still continue to work, but will raise a warning?

Looking great, thanks.

@karpetrosyan
Copy link
Member Author

karpetrosyan commented Dec 20, 2023

I'd recommend something like this.

0.26.0

Added

Deprecated

@tomchristie
Copy link
Member

Neat.

@karpetrosyan
Copy link
Member Author

@karpetrosyan karpetrosyan merged commit 08eff92 into encode:master Dec 20, 2023
5 checks passed
@tomchristie
Copy link
Member

Hrm... we don't seem to have triggered a publish event?

https://github.com/encode/httpx/actions/workflows/publish.yml

@tomchristie
Copy link
Member

Ah okay, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants