Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RFC 2069 mode digest authentication #3045

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

the-ress
Copy link
Contributor

@the-ress the-ress commented Jan 6, 2024

Summary

Fixes a typo that breaks old RFC 2069 mode digest auth.

The issue is that HA1 is added both on line 283, and again on line 293. (According to RFC, it should be there only once.)

Also mentioned in #2788 (comment)

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

httpx/_auth.py Outdated Show resolved Hide resolved
@tomchristie
Copy link
Member

I appreciated your "this branch is RFC ..." comment in #2600 (comment) - perhaps we should include those?

Also the link to the curl code is super helpful, thanks.

@the-ress
Copy link
Contributor Author

the-ress commented Jan 8, 2024

I made the discussed changes and added a few tests.

@tomchristie
Copy link
Member

Looking wonderful, thanks. ✨😊✨

You'll also want to update the CHANGELOG.md with an entry pointing at this PR.

@the-ress
Copy link
Contributor Author

the-ress commented Jan 9, 2024

You'll also want to update the CHANGELOG.md with an entry pointing at this PR.

Done.

@tomchristie tomchristie merged commit 99cba6a into encode:master Jan 10, 2024
5 checks passed
@the-ress the-ress deleted the fix-rfc-2069-digest-auth branch January 15, 2024 21:57
@tomchristie tomchristie mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants