Deprecate app=... in favor of explicit WSGITransport/ASGITransport.
#3050
Conversation
|
This is not deprecation of |
CHANGELOG.md
Outdated
| @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Removed | |||
|
|
|||
| * The `app=...` shortcut has been removed. Use the explicit style of `transport=httpx.WSGITransport()` or `transport=httpx.ASGITransport()` instead. | |||
There was a problem hiding this comment.
Since this PR is version 1.0 proposal, why don't you track its changelog in #3069 ?
There was a problem hiding this comment.
There was a problem hiding this comment.
Then do we need to re-mention it in this PR?
All other open PRs with 1.0 proposal tag don't include changelog independently.
There was a problem hiding this comment.
They should do before approval.
(We should include CHANGELOG entries with the PRs as usual.)
Yep, so... #3069 There's a proposal for several related changes, that end up with a stricter simpler more consistent API. |
Thanks @Kludex, based on this I've updated the PR to be just a deprecation at this point. Once this is merged I'll look at rolling a 0.27 version with the updated docs. |
…rt`. (encode#3050) * Deprecate app=... in favour of explicit WSGITransport/ASGITransport * Linting * Linting * Update WSGITransport and ASGITransport docs * Deprecate app * Drop deprecation tests * Add CHANGELOG * Deprecate 'app=...' shortcut, rather than removing it. * Update CHANGELOG * Fix test_asgi.test_deprecated_shortcut
|
There's one more section of docs that needs to be updated - the API reference for Client and AsyncClient don't yet mention that the |
Deprecate the
httpx.Client(app=...)andhttpx.AsyncClient(app=...)shortcuts.Instead of...
Use this...
Instead of...
Use this...
The rationale for this is described in #947 (comment).
TODO:
CHANGELOG.md.Ensure we have a clear section where we outline 1.0 version changes in one place.See Draft 1.0 release notes #3069