Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ obey retry after delay #3103

Closed
wants to merge 4 commits into from

Conversation

ndaWefox
Copy link

Summary

Obey retry after as defined by the specifications

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@ndaWefox ndaWefox marked this pull request as ready for review February 21, 2024 16:01
@ndaWefox
Copy link
Author

This issue was raised on Retry requests.

Proposition was to add a transport layer but it will not suffice, as if the redirection is done by the transport layer, then the history will be lost due to the behavior of Client._send_handling_redirects

@tomchristie
Copy link
Member

Ah thanks for getting involved.
We'd really need this to be started as a discussion first, tho it is helpful to see how you've resolved it.

Proposition was to add a transport layer but it will not suffice, as if the redirection is done by the transport layer, then the history will be lost due to the behavior of Client._send_handling_redirects

That's interesting... can we instead resolve that issue? Ie... if a transport returns a Response with a non-empty history, then the full history is retained, even when redirects occur?

@tomchristie
Copy link
Member

(I'm going to close this off as a pull request, but very much open to this discussion progressing... I think you've probably identified a valid issue here let's talk it through)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants