Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop concurrency backends #901

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Drop concurrency backends #901

merged 2 commits into from
Apr 10, 2020

Conversation

florimondmanca
Copy link
Member

Cleanup for #804: concurrency backends are not needed anymore as the core networking stuff is done with HTTPCore now.

Noticed this as the entire directory was not covered by tests anymore. :-)

@florimondmanca florimondmanca added the refactor Issues and PRs related to code refactoring label Apr 10, 2020
@florimondmanca florimondmanca requested a review from a team April 10, 2020 14:46
yeraydiazdiaz
yeraydiazdiaz approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@yeraydiazdiaz yeraydiazdiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0 -711, not bad @florimondmanca, not bad 😄

@florimondmanca florimondmanca merged commit af75908 into master Apr 10, 2020
@florimondmanca florimondmanca deleted the drop-backends branch April 10, 2020 16:48
@hugovk hugovk mentioned this pull request May 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeraydiazdiaz yeraydiazdiaz yeraydiazdiaz approved these changes

Assignees
No one assigned
Labels
refactor Issues and PRs related to code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florimondmanca @yeraydiazdiaz