Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename pool limit options #968

Merged
merged 12 commits into from
May 21, 2020
Merged

Rename pool limit options #968

merged 12 commits into from
May 21, 2020

Conversation

tomchristie
Copy link
Member

Closes #948

@tomchristie tomchristie added this to the v0.13 milestone May 21, 2020
@tomchristie
Copy link
Member Author

The URLLib3 changes here will become redundant after #966, but I'm going to ignore that here to keep this PR tightly scoped.

yeraydiazdiaz
yeraydiazdiaz reviewed May 21, 2020
View reviewed changes
Copy link
Contributor

@yeraydiazdiaz yeraydiazdiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we'll need to change the docs as well. 👍

httpx/_config.py Show resolved Hide resolved
florimondmanca
florimondmanca reviewed May 21, 2020
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb 🎉

Looks like we need to address the new Optional[int] from HTTPCore.

httpx/_config.py Show resolved Hide resolved
@tomchristie
Copy link
Member Author

Merged #967 into this as we're dependant on it.

florimondmanca
florimondmanca approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tomchristie tomchristie merged commit 991915a into master May 21, 2020
@tomchristie tomchristie deleted the rename-pool-limit-options branch May 21, 2020 12:26
@tomchristie tomchristie mentioned this pull request May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeraydiazdiaz yeraydiazdiaz yeraydiazdiaz left review comments

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13
Development

Successfully merging this pull request may close these issues.

Deprecate ProxyLimits naming in favour of max_connections and max_keepalive
3 participants
@tomchristie @yeraydiazdiaz @florimondmanca