Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Content-Length: 0" on POST, PUT, PATCH if required. #995

Merged
merged 2 commits into from
May 26, 2020
Merged

Add "Content-Length: 0" on POST, PUT, PATCH if required. #995

merged 2 commits into from
May 26, 2020

Conversation

tomchristie
Copy link
Member

Closes #987

@tomchristie tomchristie added the bug Something isn't working label May 25, 2020
florimondmanca
florimondmanca approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Just a small typo in the new test. 😄

tests/client/test_client.py Outdated Show resolved Hide resolved
@tomchristie @florimondmanca
Update tests/client/test_client.py
e76d2e6 
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
@tomchristie tomchristie merged commit 7c8158a into master May 26, 2020
@tomchristie tomchristie deleted the add-content-length-zero branch May 26, 2020 14:03
@tomchristie tomchristie mentioned this pull request May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content-Length header is missing in POST/DELETE/PUT/PATCH requests without body
2 participants
@tomchristie @florimondmanca