Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included create_ssl_context function to create the same context with SSLConfig and serve as API #996

Merged
merged 7 commits into from
Jul 27, 2020
Merged

Included create_ssl_context function to create the same context with SSLConfig and serve as API #996

merged 7 commits into from
Jul 27, 2020

Conversation

cansarigol
Copy link
Contributor

Refs #983

tomchristie
tomchristie reviewed May 25, 2020
View reviewed changes
docs/advanced.md Outdated Show resolved Hide resolved
tomchristie
tomchristie reviewed May 25, 2020
View reviewed changes
docs/advanced.md Outdated Show resolved Hide resolved
tomchristie
tomchristie reviewed May 25, 2020
View reviewed changes
tests/test_config.py Outdated
@@ -38,10 +36,11 @@ def test_load_ssl_config_verify_env_file(https_server, ca_cert_pem_file, config)
else str(Path(ca_cert_pem_file).parent)
)
ssl_config = SSLConfig(trust_env=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great as part of this change if we dropped using the private SSLConfig from the tests completely.
Not necessarily a blocker to getting this PR in, but might be worth a go?

tomchristie
tomchristie reviewed May 25, 2020
View reviewed changes
tests/test_config.py Outdated Show resolved Hide resolved
tomchristie
tomchristie reviewed May 25, 2020
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic stuff! I've put a few inline comments here.

There's also a bit of thinking we'll want to do wrt. if http2 properly lives on the SSL configuration, or on the transport, or both, but I'm not going to go into that here.

@tomchristie tomchristie mentioned this pull request May 25, 2020
Closed
@tomchristie tomchristie mentioned this pull request Jul 24, 2020
Merged
@tomchristie tomchristie added this to the v0.14 milestone Jul 27, 2020
@tomchristie tomchristie added the enhancement New feature or request label Jul 27, 2020
tomchristie
tomchristie approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great yup!
I'll leave it open briefly in case anyone else also want to take a review onto it, but otherwise we'll get this into 0.14.
Thanks so much !

florimondmanca
florimondmanca approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomchristie tomchristie merged commit 926a55a into encode:master Jul 27, 2020
@florimondmanca florimondmanca mentioned this pull request Jul 30, 2020
Closed
@florimondmanca florimondmanca mentioned this pull request Dec 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.
3 participants
@cansarigol @tomchristie @florimondmanca