use typing.Mapping for Response.headers (#1426)

encode · Jan 27, 2022 · 2b54f42 · 2b54f42
1 parent 5a5a5c3
commit 2b54f42
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/starlette/responses.py b/starlette/responses.py
@@ -38,7 +38,7 @@ def __init__(
         self,
         content: typing.Any = None,
         status_code: int = 200,
-        headers: dict = None,
+        headers: typing.Mapping[str, str] = None,
         media_type: str = None,
         background: BackgroundTask = None,
     ) -> None:
@@ -199,7 +199,7 @@ def __init__(
         self,
         url: typing.Union[str, URL],
         status_code: int = 307,
-        headers: dict = None,
+        headers: typing.Mapping[str, str] = None,
         background: BackgroundTask = None,
     ) -> None:
         super().__init__(
@@ -213,7 +213,7 @@ def __init__(
         self,
         content: typing.Any,
         status_code: int = 200,
-        headers: dict = None,
+        headers: typing.Mapping[str, str] = None,
         media_type: str = None,
         background: BackgroundTask = None,
     ) -> None:
@@ -268,7 +268,7 @@ def __init__(
         self,
         path: typing.Union[str, "os.PathLike[str]"],
         status_code: int = 200,
-        headers: dict = None,
+        headers: typing.Mapping[str, str] = None,
         media_type: str = None,
         background: BackgroundTask = None,
         filename: str = None,

diff --git a/starlette/templating.py b/starlette/templating.py
@@ -25,7 +25,7 @@ def __init__(
         template: typing.Any,
         context: dict,
         status_code: int = 200,
-        headers: dict = None,
+        headers: typing.Mapping[str, str] = None,
         media_type: str = None,
         background: BackgroundTask = None,
     ):
@@ -85,7 +85,7 @@ def TemplateResponse(
         name: str,
         context: dict,
         status_code: int = 200,
-        headers: dict = None,
+        headers: typing.Mapping[str, str] = None,
         media_type: str = None,
         background: BackgroundTask = None,
     ) -> _TemplateResponse: