StaticFiles returns a 5xx when filenames are too long

[etr2460]

A filename that's too long causes an OSError, which StaticFiles doesn't catch and ends up as a 5xx. Ideally I think starlette should either:

• Catch OSErrors and return a 400 (Bad Request) instead
• Provide a way for a user to define a handle error function to handle this as expected

[etr2460]

I've implemented the first solution mentioned here in #2222. Let me know if you think this is reasonable!

[Kludex]

I don't think it should be a 4xx. 🤔

You can inherit StaticFiles, and change the get_response implementation:

from starlette.exceptions import HTTPException
from starlette.staticfiles import StaticFiles

class NewStaticFiles(StaticFiles):
    async def get_response(self, path: str, scope: Scope) -> Response:
        try:
            super().get_response(path, scope)
        except OSError as exc:
            raise HTTPException(status_code=400) from exc