-
-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authentication args length check #1335
Conversation
Did someone get a chance to take a look at this and run the workflows? |
Fix linting
Yes, but this approach looks more as a workaround to me. I've developed an alternative solution on #1337, which I'm unsure if we should merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm willing to accept it now. Just a linter issue :)
Yes, I shouldn't try to fix it in the browser with no linting help haha. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LarsStegman ! 🎉
Could this fix be released in a new patch version so we can change our dependencies? |
Fix for
IndexError
when bothargs
andkwargs
are specified, resulting in the possibility of trying to access a tuple index that is higher than the tuple size.