Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add headers to UploadFile #1382

Merged
merged 9 commits into from
Jan 7, 2022
Merged

Conversation

adriangb
Copy link
Member

@adriangb adriangb commented Dec 22, 2021

Alternative / subset of #1311.

This preserves the multipart field headers for file uploads. Currently only content_type is preserved.

As per #1311 (comment), this is pretty much the same API Flask uses.

@tomchristie
Copy link
Member

Yes looks good! Just the one comment here.

@adriangb
Copy link
Member Author

adriangb commented Jan 5, 2022

Addressed, thank you! I also added a blurb to the docs.

Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic - thanks!

@adriangb adriangb merged commit f1c5049 into encode:master Jan 7, 2022
@adriangb adriangb deleted the uploadfile-headers branch November 4, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants