Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compat code for Python <= 3.6 #1616

Merged
merged 2 commits into from
May 1, 2022
Merged

Remove compat code for Python <= 3.6 #1616

merged 2 commits into from
May 1, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented May 1, 2022

The starting point for contributions should usually be a discussion

Simple documentation typos may be raised as stand-alone pull requests, but otherwise please ensure you've discussed your proposal prior to issuing a pull request.

This will help us direct work appropriately, and ensure that any suggested changes have been okayed by the maintainers.

Some cleanup after dropping support for EOL Python 3.6 in #1357.

Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hugovk ! :)

@Kludex
Copy link
Member

Kludex commented May 1, 2022

For the record, this PR removes the compat code that was missed on #1357.

NOTE: I didn't notice this information was already on the description. I was just redundant. 😅

@Kludex Kludex merged commit 589df78 into encode:master May 1, 2022
@hugovk hugovk deleted the rm-3.6 branch May 1, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants