Add middleware per Router
#2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
requested review from
alex-oleshkevich,
adriangb,
florimondmanca and
abersheeran
Kludex
commented
Nov 28, 2023
| @@ -650,6 +652,11 @@ def __init__( | |||
| else: | |||
| self.lifespan_context = lifespan | |||
|
|
|||
| self.middleware_stack = self.app | |||
There was a problem hiding this comment.
I know you'll comment about the names, but I prefer them.
iudeen
approved these changes
Dec 1, 2023
Kludex
force-pushed
the
middleware-per-router
branch
from
de102eb
to
11d5b8c
Compare
|
@encode/maintainers someone else wants to review this? |
abersheeran
reviewed
Dec 1, 2023
| @@ -615,6 +615,8 @@ def __init__( | |||
| # the generic to Lifespan[AppType] is the type of the top level application | |||
| # which the router cannot know statically, so we use typing.Any | |||
| lifespan: typing.Optional[Lifespan[typing.Any]] = None, | |||
| *, | |||
| middleware: typing.Optional[typing.Sequence[Middleware]] = None, | |||
There was a problem hiding this comment.
Maybe use name middlewares?
There was a problem hiding this comment.
But we use middleware everywhere already...
There was a problem hiding this comment.
😂 Oh, I didn't even notice that.
abersheeran
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.