Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop when using StreamingResponse with ASGI client #912

Closed
wants to merge 2 commits into from
Closed

Fix infinite loop when using StreamingResponse with ASGI client #912

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57db734
Workaround potential infinite loop in StreamingResponse
JayH5 Apr 23, 2020
63a091f
Merge branch 'master' into gh-908/stream-infinite-loop
JayH5 May 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions starlette/responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import asyncio
import hashlib
import http.cookies
import inspect
Expand Down Expand Up @@ -202,6 +203,11 @@ async def listen_for_disconnect(self, receive: Receive) -> None:
message = await receive()
if message["type"] == "http.disconnect":
break
# Relinquish control to the event loop to allow it to check if
# stream_response has completed. The receive() call above may not have
# handed control over to the loop, especially if there isn't actually a
# network between us and the client (e.g. when testing).
await asyncio.sleep(0)

async def stream_response(self, send: Send) -> None:
await send(
Expand Down