Raise Disconnect on send() when client disconnected
#2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Kludex
commented
Jan 17, 2024
Kludex
commented
- Comply with Add an IOError when send() is called on a closed connection django/asgiref#431.
adriangb
reviewed
Jan 18, 2024
uvicorn/protocols/utils.py
Outdated
| @@ -6,6 +6,10 @@ | |||
| from uvicorn._types import WWWScope | |||
|
|
|||
|
|
|||
| class Disconnected(IOError): | |||
I don't know yet, but shouldn't be a blocker for this PR. |
|
Ok just wanted to know it will be handled in a future PR |
adriangb
approved these changes
Jan 18, 2024
I have personal plans to work on this on the next days, but I don't want to promise. 👀 |
|
No need to promise. I just wanted to make sure you're not proposing that it doesn't get implemented by anyone at any time (i.e. this PR is all we're going to do). |
Kludex
force-pushed
the
ioerror-on-send
branch
from
c11e0b0
to
5df891f
Compare
graingert
reviewed
Jan 29, 2024
| @@ -6,6 +6,10 @@ | |||
| from uvicorn._types import WWWScope | |||
|
|
|||
|
|
|||
| class ClientDisconnected(IOError): | |||
There was a problem hiding this comment.
IOError is an alias for OSError on python 3
There was a problem hiding this comment.
Ouch I think we put IOError in the spec...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.