Rework IPv6 support #837
Merged
Rework IPv6 support #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
force-pushed
the
fm/ipv6
branch
from
6636fb7
to
08a92c0
Compare
euri10
reviewed
Oct 26, 2020
There was a problem hiding this comment.
Looks good to me @florimondmanca , I just left minor comments
euri10
approved these changes
Oct 26, 2020
Co-authored-by: euri10 <euri10@users.noreply.github.com>
florimondmanca
commented
Oct 26, 2020
florimondmanca
commented
Oct 26, 2020
|
@euri10 Thanks for your comment on #837 (comment) — good point, just updated the PR to remove un,ecessary changes. |
|
no idea if github has an issue with their workflow at the moment but I had
to cancel the CI which was locked on Run tests after 13min, then pressed
re-run all jobs and it seems stuck again...you see this also on other
projects ?
…On Mon, Oct 26, 2020 at 3:08 PM Florimond Manca ***@***.***> wrote:
@euri10 <https://github.com/euri10> Thanks for your comment on #837
(comment)
<#837 (comment)> — good
point, just updated the PR to remove un,ecessary changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#837 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAINSPRVB5RM3BMKIO34YXDSMV7E5ANCNFSM4S5W2RFQ>
.
--
benoit barthelet
http://pgp.mit.edu/pks/lookup?op=get&search=0xF150E01A72F6D2EE
|
|
nah actually @florimondmanca I think you went too far in diff reduction, you need to revert last commit 01ffc58 because it's on the |
|
@euri10 Yup, thanks — should be fixed now, CI should pass but let's see. :-) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by #836 (comment)
It looks like IPv6 support as added (or most likely fixed? I found #383 dating back from June 2019) into
0.12.2to resolve #553. This was done via #803, which glossed over a small edge case leading tohost="localhost"not working anymore, leading to issue #825, and then a fix via #827.But @euri10 mentioned in #827 that the fix wasn't the prettiest, so I went ahead and started this whole thing all over — here's what I did in this PR…
test_run()test so that it tests all three cases: default case (127.0.0.1), DNS hostname (localhost), and IPv6 ([::]).--hostnow supports IPv6 addresses, with an example.It might be easy to review commit-by-commit, since the overall diff conflates reverts and the actual re-implementation. :-)
Note: for the changelog, we'll probably want to not mention #827, and mention this PR instead (if we decide to merge it).