Make WSGI implementation agnostic to async library #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
force-pushed
the
fm/asyncio-agnostic-wsgi
branch
from
f99db9d
to
d89fbb4
Compare
florimondmanca
force-pushed
the
fm/asyncio-agnostic-wsgi
branch
from
d89fbb4
to
7961d6a
Compare
|
Closing for now, see #842 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #844
Last part of stage 1 of #169 (comment): rework
WSGIMiddlewareso that it calls intoAsyncBackendrather thanasynciodirectly.This is the gnarliest of refactor PRs, since this component does some close concurrency. I know the
backend.call_soon()method won't stay here whentriois added (trio doesn't have such a "schedule a callback from outside the event loop" API), and we'll need to refactor this, but for now the goal is to have some abstraction without changing too much the implementation logic. Tests pass locally, so I'm happy (but let's see what CI says).