Modernize test ASGI applications

[florimondmanca]

Small refactoring PR that cleans up a bunch of test code, replacing the older ASGI 2.0 style:

class App:
    def __init__(self, scope):
        ...

    async def __call__(self, receive, send):
        ...

With an up-to-date ASGI 3.0 style:

async def app(scope, receive, send):
    ...

Also reduce code duplication in tests that were just using a sample "empty response" app.

[euri10]

Much love 💗 for net deletion, I left a small suggestion but this can go without !

[euri10]

Nah just wanted to say that in this PR or another the CustomServer could be refactored as well, it's currently duplicated all over

…

On Wed, Nov 18, 2020, 9:21 PM Florimond Manca ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In tests/middleware/test_trace_logging.py <#854 (comment)>: > @pytest.mark.skipif( sys.platform.startswith("win") or platform.python_implementation() == "PyPy", reason="Skipping test on Windows and PyPy", ) def test_trace_logging(capsys): - class App: - def __init__(self, scope): - if scope["type"] != "http": - raise Exception() - - async def __call__(self, receive, send): - await send({"type": "http.response.start", "status": 204, "headers": []}) - await send({"type": "http.response.body", "body": b"", "more_body": False}) - class CustomServer(Server): Not sure what you mean here exactly — the CustomServer is left untouched? Only the ASGI apps are modified and factored out. Did you mean that the individual ASGI apps were modified as well? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#854 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAINSPXSYQYDJKPD6XNWYZLSQQUFTANCNFSM4T2MGFEA> .

[florimondmanca]

in this PR or another the CustomServer could be refactored as well, it's currently duplicated all over

Yup ;-)