Move server implementation to server.py #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayH5
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #842
#842 moved the
Servercode to an_impl/asyncio.pymodule anticipating support for multiple async environments, but this was obviously premature. I've now learnt through #863 that this just won't be as easy as "one server implementation per async library" (well it could be, but that would be at a huge code duplication cost).This PR reverts back to a more stable and simple state: a
server.pymodule. The sole purpose is that we have this isolated in a module, and not cluggering up themain.pymodule —main.pyshould be focused on the CLI.