Added "Service" postfix to App::Set/GetRegistry() and Set/GetLogger().

Add a comment in IWhatEverService interface declarations that it is required to keep the core decoupled from something.
#134 #137

src/core/ActionProperty.cpp

@@ -171,7 +171,7 @@ namespace shellanything
     // If regisrykey is specified, it has priority over value. This is required to allow setting a property to an empty value (a.k.a. value="").
     if (!regisrykey.empty())
     {
-      IRegistryService* registry = App::GetInstance().GetRegistry();
+      IRegistryService* registry = App::GetInstance().GetRegistryService();
       if (registry == NULL)
       {
         SA_LOG(ERROR) << "No Registry service configured for evaluating registrykey expression '" << regisrykey << "'.";

src/core/App.cpp

@@ -85,22 +85,22 @@ namespace shellanything
     mClipboard = NULL;
   }
 
-  void App::SetLogger(ILoggerService* logger)
+  void App::SetLoggerService(ILoggerService* logger)
   {
     mLogger = logger;
   }
 
-  ILoggerService* App::GetLogger()
+  ILoggerService* App::GetLoggerService()
   {
     return mLogger;
   }
 
-  void App::SetRegistry(IRegistryService* instance)
+  void App::SetRegistryService(IRegistryService* instance)
   {
     mRegistry = instance;
   }
 
-  IRegistryService* App::GetRegistry()
+  IRegistryService* App::GetRegistryService()
   {
     return mRegistry;
   }

src/core/App.h

@@ -74,13 +74,13 @@ namespace shellanything
     /// If a logger instance is already set, the caller must properly destroy the old instance.
     /// </remarks>
     /// <param name="logger">A valid instance of a ILogger.</param>
-    void SetLogger(ILoggerService* logger);
+    void SetLoggerService(ILoggerService* logger);
 
     /// <summary>
     /// Get the current application logger
     /// </summary>
     /// <returns>Returns a pointer to an ILogger instance. Returns NULL if no logger is set.</returns>
-    ILoggerService* GetLogger();
+    ILoggerService* GetLoggerService();
 
     /// <summary>
     /// Set the current application registry service.
@@ -89,13 +89,13 @@ namespace shellanything
     /// If a service instance is already set, the caller must properly destroy the old instance.
     /// </remarks>
     /// <param name="instance">A valid instance of a the service.</param>
-    void SetRegistry(IRegistryService* instance);
+    void SetRegistryService(IRegistryService* instance);
 
     /// <summary>
     /// Get the current application registry service.
     /// </summary>
     /// <returns>Returns a pointer of the instance that is currently set. Returns NULL if no service is set.</returns>
-    IRegistryService* GetRegistry();
+    IRegistryService* GetRegistryService();
 
     /// <summary>
     /// Set the current application clipboard service.

src/core/IClipboardService.h

@@ -34,6 +34,7 @@ namespace shellanything
 {
   /// <summary>
   /// Abstract clipboard service class.
+  /// Used to decouple the core from Windows Operating System API.
   /// </summary>
   class SHELLANYTHING_EXPORT IClipboardService
   {

src/core/ILoggerService.h

@@ -32,6 +32,7 @@ namespace shellanything
 {
   /// <summary>
   /// Abstract logger class.
+  /// Used to decouple the core from the current logging framework.
   /// </summary>
   class SHELLANYTHING_EXPORT ILoggerService
   {

src/core/IRegistryService.h

@@ -33,7 +33,8 @@
 namespace shellanything
 {
   /// <summary>
-  /// Abstract registry handling class.
+  /// Abstract registry service class.
+  /// Used to decouple the core from Windows Operating System API.
   /// </summary>
   class SHELLANYTHING_EXPORT IRegistryService
   {
@@ -57,7 +58,6 @@ namespace shellanything
 
   };
 
-
 } //namespace shellanything
 
 #endif //SA_IREGISTRY_SERVICE_H

src/core/LoggerHelper.cpp

@@ -44,7 +44,7 @@ namespace shellanything
   LoggerHelper::~LoggerHelper()
   {
     // Log the streamed content to the actual logger
-    ILoggerService * logger = App::GetInstance().GetLogger();;
+    ILoggerService * logger = App::GetInstance().GetLoggerService();;
 
     if (logger)
     {

src/shellextension/dllmain.cpp

@@ -369,11 +369,11 @@ extern "C" int APIENTRY DllMain(HINSTANCE hInstance, DWORD dwReason, LPVOID lpRe
 
       // Setup an active logger in ShellAnything's core.
       logger_service = new shellanything::GlogLoggerService();
-      app.SetLogger(logger_service);
+      app.SetLoggerService(logger_service);
 
       // Setup an active registry service in ShellAnything's core.
       registry_service = new shellanything::RegistryService();
-      app.SetRegistry(registry_service);
+      app.SetRegistryService(registry_service);
 
       // Setup an active registry service in ShellAnything's core.
       clipboard_service = new shellanything::ClipboardService();

src/tests/main.cpp

@@ -125,11 +125,11 @@ int main(int argc, char** argv)
 
   // Setup an active logger service in ShellAnything's core.
   shellanything::ILoggerService* logger_service = new shellanything::GlogLoggerService();
-  app.SetLogger(logger_service);
+  app.SetLoggerService(logger_service);
 
   // Setup an active registry service in ShellAnything's core.
   shellanything::IRegistryService* registry_service = new shellanything::RegistryService();
-  app.SetRegistry(registry_service);
+  app.SetRegistryService(registry_service);
 
   // Setup an active registry service in ShellAnything's core.
   shellanything::IClipboardService* clipboard_service = new shellanything::ClipboardService();