Merge branch feature-issue109. #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Property `system.logging.verbose` or environment variable `SA_OPTION_LOGGING_VERBOSE` can be set to a value that evaluates to true to enable/disable verbose logging. The environment variable has priority over the local property.
… configuration file. #109
… with PropertyManager.
…ings(). Also added a non-verbose scope logger for clarity.
…more now that we are using `ScoperLogger` class.
* master: Update sa_plugin_services.cpp. Removed double LF in logs from the plugin. Fixed a bug in LoggerHelper.cpp where logging without a filename had potential of crashing the application Updated workflows warnings for deprecated actions. Fixes the following warnings: ``` Deprecation notice: v1, v2, and v3 of the artifact actions The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "Installation packages.", "unit-test-logs", "unit-test-results". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ build The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-python@v4, exuanbo/actions-deploy-gist@v1, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ ```
…such as ToHex(). Fixed instance address printing in LoggerHelper class. Updated code that print a Menu description.
Created new test for validating implementation: `TestIObject.testToLongString`.
…g functions/scopes. Changed Menu class description to use Menu::ToShortString() value instead. Replaced usage of `Win32Utils::GetMenuTree()` by `ConfigManager::ToLongString()`. This will only print data from ShellAnything and not "the other shell extensions menu items.
…nes). Also the declaration is more human readable than having 2-4 arguments.
…NFO::instance` is specified. SKipped setting `INFO::instance` to debug instance address for singleton object. The address never change.
…by default. Added more tests in TestLoggerHelper to validate LoggerHelper features.
…INFO` to prevent confusion with and `SA_LOG(INFO)` calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109