Fetch all Kolibri content nodes #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Kolibri filters the content nodes to download by the types of content the instance can render. For the content server we want to fully mirror the channel and download all nodes regardless of whether the content can be rendered or not. To do that, the API request is made with the `renderable_only` option set to `False`. For better or worse, Kolibri 0.15 ignores unknown options, so this will only do anything useful if the content server handles the `renderable_only` option[1]. 1. learningequality/kolibri#11513 Helps: endlessm/endless-key-content-private#103
By default, Kolibri only imports content nodes that the current instance has a renderer for. Since we're operating on a homedir that may be missing plugins that are available at runtime (such as the zim plugin), it may skip nodes that we ultimately want at runtime. Use the `--include-unrenderable-content` option so that no nodes are filtered out. Helps: endlessm/endless-key-content-private#103
|
Yep, this makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kolibri defaults to only downloading content nodes that it believes the current instance can render. Both the image builder and the content server have Kolibri instances that don't necessarily have all available content renderers. To be safe they should download content nodes without regard for whether Kolibri thinks they're renderable. For the
importcontentCLI, that's the--include-unrenderable-contentoption. For the task API, that's therenderable_onlyoption.Helps: https://github.com/endlessm/endless-key-content-private/issues/103