-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defaults: add Decibels & Music #158
Conversation
Can/should this be just under `apps_add` since Decibels will handle opening audio files? https://phabricator.endlessm.com/T32696
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these should be mandatory, I think they should be in apps_add
(i.e. not present in the base
image), as Rhythmbox is.
And, presumably you intended to remove Rhythmbox from the defaults?
@wjt ah, I saw Totem there and thought Decibels served a similar purpose; without it, I guess audio files will just open in Totem? I agree Music should replace Rhythmbox in |
@@ -502,7 +503,7 @@ apps_add = | |||
org.gimp.GIMP | |||
org.gnome.Cheese | |||
org.gnome.Gnote | |||
org.gnome.Rhythmbox3 | |||
org.gnome.Music |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very convenient that they fall in the same place in the sort order!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed!
@@ -466,6 +466,7 @@ apps_add_mandatory = | |||
[flatpak-remote-flathub] | |||
repo_file = https://dl.flathub.org/repo/flathub.flatpakrepo | |||
apps_add_mandatory = | |||
com.vixalien.decibels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, on second thoughts, your line of reasoning makes sense: being able to play audio files is essential functionality, so decibels should go here; while having a music library app is not.
https://phabricator.endlessm.com/T32696