Add firefox automation #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benji Visser <benji@093b.org>
Signed-off-by: Benji Visser <benji@093b.org>
marcwrobel
requested changes
Jan 6, 2023
Signed-off-by: Benji Visser <benji@093b.org>
Signed-off-by: Benji Visser <benji@093b.org>
marcwrobel
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
LGTM. @captn3m0 do you want to take a look at this script before we merge it ?
|
Google cloud documentation errors out occasionally with SSL errors. We either retry the job manually, or the automation catches up in the next scheduled run in 4 hours typically.
We can add proper retries for individual scripts in a separate PR.
|
|
Ok, let's merge and see. Retries will have to be added if it fails often. |
We just had a timeout with the maven script. Maybe we should add a retry mechanism there too ;). |
|
Looks like the retry mechanism will be needed, already got a timeout in https://github.com/endoflife-date/release-data/actions/runs/3867095398. |
marcwrobel
added a commit
to endoflife-date/endoflife.date
that referenced
this pull request
Jan 19, 2023
marcwrobel
added a commit
to endoflife-date/endoflife.date
that referenced
this pull request
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch Firefox versions with their dates from https://www.mozilla.org/en-US/firefox/releases/
Unfortunately firefox release pages for versions <3.0 are not dated (example). Not sure where we can get this data.