Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need better dependency diagnostic for too-old node versions #125

Closed
dckc opened this issue Apr 13, 2019 · 3 comments
Closed

We need better dependency diagnostic for too-old node versions #125

dckc opened this issue Apr 13, 2019 · 3 comments

Comments

@dckc
Copy link
Contributor

dckc commented Apr 13, 2019

I just heard about release 5. I tried to follow the getting started docs to the letter; I'm losing.

connolly@jambox:/tmp/ses-5$ node ex.js 
/tmp/ses-5/ex.js:8
]
^

SyntaxError: Unexpected token ]

After fixing that typo (#114) I get:

connolly@jambox:/tmp/ses-5$ node ex.js 
/tmp/ses-5/node_modules/ses/dist/ses.cjs.js:403
  async function* aStrictAsyncGenerator() {} // eslint-disable-line no-empty-function
                ^

SyntaxError: Unexpected token *

Is my node too old?

connolly@jambox:/tmp/ses-5$ node --version
v8.14.0

If so, I think you can use some sort of engine thingy in your package.json to tell me what version(s) of node you support.

full transcript of my session: https://gist.github.com/dckc/e7bd1571c3c17110eab7110f4e319194

@erights
Copy link
Contributor

erights commented Apr 13, 2019

Is my node too old?

yes

If so, I think you can use some sort of engine thingy in your package.json to tell me what version(s) of node you support.

I thought we had one but apparently not. Leaving this issue open for that but revising the title.

@erights erights changed the title SyntaxError at ses.cjs.js:403? required node version > v8.14.0? We need better dependency diagnostic for too-old node versions Apr 13, 2019
@dckc
Copy link
Contributor Author

dckc commented Sep 28, 2019

Diagnostics are still pretty bad using stock node v8.14.0 in Ubuntu 18.04:

$ git clone https://github.com/Agoric/SES
$ cd SES
SES$ git describe
v0.6.2-1-g2669dca
SES$ npm install
added 219 packages...
connolly@jambox:/tmp/SES$ npm test

> ses@0.6.3-dev.0 test /tmp/SES
> node scripts/build-intermediate.js && tape -r esm test/**/*.js

wrote 81048 to src/stringifiedBundle
/tmp/SES/src/bundle/anonIntrinsics.js:106
  async function* aStrictAsyncGenerator() {} // eslint-disable-line no-empty-function
                ^

SyntaxError: Unexpected token *
    at Object.Module._extensions..js (module.js:664:10)

@jfparadis jfparadis transferred this issue from Agoric/SES Feb 21, 2020
@kriskowal
Copy link
Member

Tracking on #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants