Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SES: Adapt Native XS Compartment to SES Compartment #2251

Open
Tracked by #400
kriskowal opened this issue Apr 29, 2024 · 0 comments
Open
Tracked by #400

SES: Adapt Native XS Compartment to SES Compartment #2251

kriskowal opened this issue Apr 29, 2024 · 0 comments

Comments

@kriskowal
Copy link
Member

kriskowal commented Apr 29, 2024

Refs: #400

Add a Compartment adapter to ses such that the SES Compartment wraps the XS native Compartment providing parity with the current ses Compartment interface using the XS native implementation.

  • One of:
    - SES: Introduce XS-specific Compartment interface-parity-adapter around native Compartment such that existing usage requires no changes.
    - Refactor SES Compartment to implement the XS Native Compartment API more directly and adjust Compartment Mapper to use these new forms.
    - Refactor Compartment Mapper such that it drives ModuleSource and Module constructors directly and subsumes some dependency analysis responsibilities from Compartment.
@kriskowal kriskowal changed the title Add a Compartment adapter to ses such that the SES Compartment wraps the XS native Compartment providing parity with the current ses Compartment interface using the XS native implementation. SES: Adapt Native XS Compartment to SES Compartment Apr 29, 2024
kriskowal added a commit that referenced this issue Jul 15, 2024
Refs: #400 #2251 

## Description

Pursuant to arriving at parity with XS, this change internally reörients
the SES module loader around the concept of a “module descriptor”. This
creates some clarity and removes some existing duplication of work for
“alias” module descriptors, and prepares the material for a richer
module descriptor schema to match those implemented by XS.

### Security Considerations

No changes.

### Scaling Considerations

No changes.

### Documentation Considerations

No changes.

### Testing Considerations

No changes.

### Compatibility Considerations

No changes.

### Upgrade Considerations

No changes.
kriskowal added a commit that referenced this issue Jul 16, 2024
Refs: #400
#2251

## Description

This change introduces support for XS-compatible module descriptors with
the discriminating properties `source` and `namespace`, including
support for loading a module from the parent compartment.

### Security Considerations

None.

### Scaling Considerations

None.

### Documentation Considerations

This change is additive.

### Testing Considerations

Covered.

### Compatibility Considerations

Some usage patterns are now deprecated but continue to be supported
without complaint.

### Upgrade Considerations

None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant