-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bundle-source): Add tag
command-line flag
#2353
Conversation
Are there better behaved non-default build conditions? |
nevermind. I get it now. |
5aae1bb
to
e213afd
Compare
2a27d95
to
8b91e9a
Compare
e213afd
to
b959d25
Compare
8b91e9a
to
81152c9
Compare
b959d25
to
b82a4c4
Compare
3b2b329
to
deb7498
Compare
1485897
to
ef30b9b
Compare
2860316
to
0ac5006
Compare
ef30b9b
to
a7c3037
Compare
0ac5006
to
bbddde7
Compare
a7c3037
to
4944670
Compare
bbddde7
to
db65fb1
Compare
db65fb1
to
b9dad87
Compare
4944670
to
6e0ece6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple! LGTM!
it = ? I'm not sure I'm following. |
An Endo script bundle that captures our |
6e0ece6
to
7d12a65
Compare
b9dad87
to
11f6cc7
Compare
7d12a65
to
b7c37d4
Compare
2417123
to
304abb4
Compare
b7c37d4
to
1412380
Compare
304abb4
to
4f642be
Compare
1412380
to
47ca36d
Compare
4f642be
to
ba1f346
Compare
47ca36d
to
24fc227
Compare
Refs: #400
Description
We’ve discovered that, to create an Endo script bundle that captures our
ModuleSource
constructor shim, it will need to entrain Babel. With the default build conditions, Babel entrains adebug
package, which entrainsnode:tty
. So, it is necessary to add the"browser"
condition, which instead entrains a package with a JSON module (#2352). This change threads arbitrary conditions (build tags) throughbundle-source
to conveniently generate Endo script bundles with different tags likebrowser
orxs
.Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
The new flags are advertised in the command’s usage display.
Testing Considerations
Compatibility Considerations
None.
Upgrade Considerations
None.