Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ses,pass-style,marshal): fix #2428 permit disposal intrinsics #2429

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erights
Copy link
Contributor

@erights erights commented Aug 27, 2024

Closes: #2428
Refs: #2223

Description

https://github.com/tc39/proposal-explicit-resource-management has reached stage 3 awhile ago, so we should permit its intrinsics before it gets rolled out widely.

Besides, once it is available on enough target platforms, we'd like to start using it.

This PR merely adds special cases for SuppressedError paralleling the special cases we already had for AggregateError. A follow-on PR #2223 should generalize the handling of novel safe error properties so we no longer need to do such bespoke error handling.

Security Considerations

While https://github.com/tc39/proposal-explicit-resource-management was going through stages, we were involved and believe that the proposal as accepted has no security issues. This PR unconditionally permits it with no further repair under the assumption that all platforms of interest, if they implement it at all, implement it correctly.

Scaling Considerations

For this PR by itself, none.

https://github.com/tc39/proposal-explicit-resource-management should help us write code that more reliably cleans up after itself, which should help scalability.

Documentation Considerations

By supporting https://github.com/tc39/proposal-explicit-resource-management before it is widely available, we avoid the need to document its omission.

Testing Considerations

  • need tests for SuppressedError handling that parallels the tests we have for AggregateError

Compatibility Considerations

As with AggregateError, we need to make sure that SuppressedError can be received correctly by all endpoints of interest before we can start sending it.

Upgrade Considerations

  • update all relevant NEWS.md files.

@erights erights self-assigned this Aug 27, 2024
@erights erights changed the title fix(ses,pass-style,marshal): fix 2428 permit disposal intrinsics fix(ses,pass-style,marshal): fix #2428 permit disposal intrinsics Aug 27, 2024
@erights erights marked this pull request as ready for review August 27, 2024 02:19
@erights erights marked this pull request as draft August 27, 2024 21:49
@erights
Copy link
Contributor Author

erights commented Aug 27, 2024

Converting to Draft because its current form is too messy to consider as a candidate. I'll let you know when it is again ready for review.

@erights erights force-pushed the markm-anticipate-disposal branch 2 times, most recently from 611ea5b to 62895a4 Compare September 2, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permit intrinsics from proposal-explicit-resource-management
1 participant