refactor: Errors do not need "new"

[erights]

Closes: #XXXX
Refs: Agoric/agoric-sdk#10030

Description

Errors do not need new

For all construction calls to a *Error constructor, the new is not needed. IOW, just calling the *Error constructor as a function has the same effect.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

none

Compatibility Considerations

none

Upgrade Considerations

none

[turadg]

If this change is worth making, it's worth making durably.

Requesting that the lint rules be configured to error on new Error:

{
  "rules": {
    "no-restricted-syntax": [
      "error",
      {
        "selector": "NewExpression[callee.name='Error']",
        "message": "Use Error(msg) instead of new Error(msg)"
      }
    ]
  }
}

[mhofman]

Requesting that the lint rules be configured to error on new Error:

Should this handle other Error constructors, maybe with a RegExp attribute selector?

[gibson042]

Requesting that the lint rules be configured to error on new Error:

Should this handle other Error constructors, maybe with a RegExp attribute selector?

Yes!

{
  "rules": {
    "no-restricted-syntax": [
      "error",
      {
        "selector": "NewExpression[callee.name=/^([A-Z]\\w*)?Error$/]",
        "message": "Use Error(msg) instead of new Error(msg)"
      }
    ]
  }
}

[boneskull]

👍 assuming ESLint is configured to enforce this (either in this PR or a different one).