Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ses): package test correctly rejects instead of uncaught exception #2566

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(ses): package test correctly rejects instead of uncaught exception #2566

merged 1 commit into from
Oct 3, 2024

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Oct 3, 2024

test assertion failure outside of the test function leads to uncaught exception

@kumavis kumavis requested a review from turadg October 3, 2024 07:56
turadg
turadg approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kumavis kumavis merged commit d0d2554 into master Oct 3, 2024
15 checks passed
@kumavis kumavis deleted the ses-test-fix-uncaught branch October 3, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumavis @turadg