Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(endo): Module specifier and URL math #342

Merged
merged 7 commits into from
Jun 24, 2020
Merged

feat(endo): Module specifier and URL math #342

merged 7 commits into from
Jun 24, 2020

Commits on Jun 24, 2020

  1. Remove lint stub

    @kriskowal
    kriskowal committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    c20d34e View commit details
    Browse the repository at this point in the history

  2. Avoid linting build products

    @kriskowal
    kriskowal committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    cda87e1 View commit details
    Browse the repository at this point in the history

  3. feat(endo): Add Node.js module specifier math 

    The Node.js package.json allows relative or absolute module specifiers
like `"main": "./index.js"` or `"main": "index.js"`.
The `relativize` function normalizes all such paths to their relative
form since Endo compartments use absolute specifiers for external
linkage and relative specifiers for internal linkage.
It is not possible for `package.json` to express a module specifier
that refers to a module in another package.

The join function joins an absolute module specifier to a relative
module specifier.
Creating a compartment map joins external dependency package names to
internal module specifiers.
The external dependency specifier must be absolute and the internal
module specifier must be relative.

Endo uses this resolve function for all compartment resolve hooks.
The referrer is always a relative module specifier like "./index.js".
The referent may be relative to import a module in the same package, or
absolute to import an external dependency, either a built-in module or a
module from a third-party package.
    @kriskowal
    kriskowal committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    e4f6023 View commit details
    Browse the repository at this point in the history

  4. feat(endo): Add URL relative

    @kriskowal
    kriskowal committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    e1466aa View commit details
    Browse the repository at this point in the history

  5. Add test infrastructure

    @kriskowal
    kriskowal committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    7afb1c7 View commit details
    Browse the repository at this point in the history

  6. Address path math feedback

    @kriskowal
    kriskowal committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    f099a6d View commit details
    Browse the repository at this point in the history

  7. Address lint

    @kriskowal
    kriskowal committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    a7f8be3 View commit details
    Browse the repository at this point in the history