Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ses): Add Compartment load function #349

Merged
merged 1 commit into from
Jul 24, 2020
Merged

feat(ses): Add Compartment load function #349

merged 1 commit into from
Jul 24, 2020

Conversation

kriskowal
Copy link
Member

This change surfaces the load function so compartments can be used to create archives without executing any of the assembled modules.

@kriskowal kriskowal requested a review from erights June 18, 2020 22:07
@kriskowal kriskowal force-pushed the kris/ses-load branch 2 times, most recently from d223af1 to f14b767 Compare June 19, 2020 00:33
@kriskowal kriskowal mentioned this pull request Jun 19, 2020
36 tasks
@kriskowal kriskowal force-pushed the kris/ses-load branch 2 times, most recently from 32ae52e to 2fa05f3 Compare June 19, 2020 19:08
@kriskowal kriskowal force-pushed the kris/ses-load branch 2 times, most recently from 1f9ba27 to 7787dad Compare June 19, 2020 20:21
@kriskowal kriskowal force-pushed the kris/ses-load branch 2 times, most recently from 9e80fe7 to 555c2ba Compare June 24, 2020 03:00
@kriskowal kriskowal force-pushed the kris/ses-load branch 2 times, most recently from 355ce93 to e4fca02 Compare June 24, 2020 20:47
@kriskowal kriskowal force-pushed the kris/ses-load branch 3 times, most recently from a77691c to da13c5c Compare June 30, 2020 20:12
@erights
Copy link
Contributor

erights commented Jul 11, 2020

This PR is a delta on the ses-load branch. But is there a PR for the ses-load branch? I could not find one.

@kriskowal
Copy link
Member Author

This PR is a delta on the ses-load branch. But is there a PR for the ses-load branch? I could not find one.

This PR should contain one commit that can be cherry-picked on master. This PR tracks the kris/ses-load branch and its differences atop the kris/endo-zip branch.

@kriskowal
Copy link
Member Author

@erights This change is now at the head of the Endo queue and rebased so it should only show one commit again. (The artifact you saw was the product of the squash merge of another change in the queue; I need to promptly rebase the stack each time I land a change so you don’t see these intermediate states).

Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriskowal kriskowal merged commit 8352fa1 into master Jul 24, 2020
@kriskowal kriskowal deleted the kris/ses-load branch July 24, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants