Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(endo): Add search #353

Merged
merged 2 commits into from
Jul 21, 2020
Merged

feat(endo): Add search #353

merged 2 commits into from
Jul 21, 2020

Conversation

kriskowal
Copy link
Member

A Node.js application is a module and its transitive dependencies.
To provide as close an approximation of Node.js, running an Endo
application is also the importing of an entry module.
To construct the compartment graph for the module, the search
function starts with a path to the module and searches for
the first parent directory that contains a "package.json".

Node.js does not require there to be a "package.json".
Neither do web applications using ESM or Deno applications.
This is a constraint that we might relax in a future version by creating
a special compartment for entry modules.

@kriskowal kriskowal requested a review from warner June 18, 2020 22:08
@kriskowal kriskowal force-pushed the kris/endo-search branch 2 times, most recently from 9f05f9a to 9613273 Compare June 19, 2020 00:33
@kriskowal kriskowal mentioned this pull request Jun 19, 2020
36 tasks
@kriskowal kriskowal force-pushed the kris/endo-search branch 6 times, most recently from b096403 to e656cab Compare June 24, 2020 02:56
@kriskowal kriskowal force-pushed the kris/endo-search branch 2 times, most recently from 3a11ffd to 5bec88c Compare June 24, 2020 03:09
Copy link
Contributor

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kriskowal kriskowal force-pushed the kris/endo-compartmap branch 2 times, most recently from 1a82660 to a22d329 Compare June 30, 2020 18:56
@kriskowal kriskowal force-pushed the kris/endo-search branch 3 times, most recently from 37bbe67 to fb56681 Compare June 30, 2020 20:12
@kriskowal kriskowal force-pushed the kris/endo-search branch 2 times, most recently from c948940 to 681406f Compare July 21, 2020 00:22
Base automatically changed from kris/endo-compartmap to master July 21, 2020 00:56
A Node.js application is a module and its transitive dependencies.
To provide as close an approximation of Node.js, running an Endo
application is also the importing of an entry module.
To construct the compartment graph for the module, the search
function starts with a path to the module and searches for
the first parent directory that contains a "package.json".

Node.js does not require there to be a "package.json".
Neither do web applications using ESM or Deno applications.
This is a constraint that we might relax in a future version by creating
a special compartment for entry modules.
@kriskowal kriskowal merged commit a250d22 into master Jul 21, 2020
@kriskowal kriskowal deleted the kris/endo-search branch July 21, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants