-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(endo): Add search #353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kris/endo-compartmap
branch
from
June 18, 2020 23:10
14a4e21
to
fbc3d57
Compare
kriskowal
force-pushed
the
kris/endo-search
branch
2 times, most recently
from
June 19, 2020 00:33
9f05f9a
to
9613273
Compare
kriskowal
force-pushed
the
kris/endo-search
branch
6 times, most recently
from
June 24, 2020 02:56
b096403
to
e656cab
Compare
kriskowal
force-pushed
the
kris/endo-compartmap
branch
from
June 24, 2020 03:00
d244a66
to
ad44af8
Compare
kriskowal
force-pushed
the
kris/endo-search
branch
2 times, most recently
from
June 24, 2020 03:09
3a11ffd
to
5bec88c
Compare
kriskowal
force-pushed
the
kris/endo-compartmap
branch
from
June 24, 2020 20:47
0f89e68
to
14e8b28
Compare
kriskowal
force-pushed
the
kris/endo-search
branch
from
June 24, 2020 20:47
5bec88c
to
0eeebe7
Compare
warner
approved these changes
Jun 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
kriskowal
force-pushed
the
kris/endo-compartmap
branch
2 times, most recently
from
June 30, 2020 18:56
1a82660
to
a22d329
Compare
kriskowal
force-pushed
the
kris/endo-search
branch
3 times, most recently
from
June 30, 2020 20:12
37bbe67
to
fb56681
Compare
kriskowal
force-pushed
the
kris/endo-search
branch
2 times, most recently
from
July 21, 2020 00:22
c948940
to
681406f
Compare
kriskowal
force-pushed
the
kris/endo-compartmap
branch
from
July 21, 2020 00:52
53ec126
to
4f10753
Compare
kriskowal
force-pushed
the
kris/endo-search
branch
from
July 21, 2020 00:52
681406f
to
1530224
Compare
A Node.js application is a module and its transitive dependencies. To provide as close an approximation of Node.js, running an Endo application is also the importing of an entry module. To construct the compartment graph for the module, the search function starts with a path to the module and searches for the first parent directory that contains a "package.json". Node.js does not require there to be a "package.json". Neither do web applications using ESM or Deno applications. This is a constraint that we might relax in a future version by creating a special compartment for entry modules.
kriskowal
force-pushed
the
kris/endo-search
branch
from
July 21, 2020 20:14
1530224
to
0b59640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Node.js application is a module and its transitive dependencies.
To provide as close an approximation of Node.js, running an Endo
application is also the importing of an entry module.
To construct the compartment graph for the module, the search
function starts with a path to the module and searches for
the first parent directory that contains a "package.json".
Node.js does not require there to be a "package.json".
Neither do web applications using ESM or Deno applications.
This is a constraint that we might relax in a future version by creating
a special compartment for entry modules.