fix: correct fix for override mistake #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
reviewed
Aug 8, 2020
DavidBruant
approved these changes
Aug 10, 2020
|
And also, i think it's beautiful to fix the override mistake by enabling ses :-) |
kriskowal
approved these changes
Aug 10, 2020
erights
referenced
this pull request
in nodejs/node
Sep 3, 2020
PR-URL: #28254 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The override mistake is supposed to emulate the way assignment should have worked in the absence of the override mistake. Before this PR, when an assignment would have created a new property, the emulated assignment creates a property that inherits the enumerability and configurability of the property being overridden. But new properties actually created by assignment don't do that. They start with
writable,enumerable, andconfigurableall true.This PR still needs tests.