toward SES testing on XS (WIP) #650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
force-pushed
the
535-ava-xs
branch
3 times, most recently
from
12b7636
to
20ce61c
Compare
- add ses/lockdown to externals - fix lockdown() for test compartment to provide SES Compartment constructor
The test as written depends on stringifying functions, which XS doesn't do. erights says the test is not novel and not worth maintaining.
- import all of ses in tests that need it
- SEGV: test-global-object-mutability.js - postpone tests that require babel
|
What is the status of this PR? |
The only think I can think of that's not in the description etc. is that it's blocked on moving xsnap to endo (#681), which is not high on my list nor @kriskowal 's. I suppose if #508 and #535 still belong on the Endo 1 milestone then #681 should be there too. Thoughts, @kriskowal ? |
|
What is the status of this PR? Is it still relevant? |
|
It's tangentially relevant in that migrating xsnap to endo (#681) is still on our todo list. But I think the odds that we'll actually use these bits to accomplish that are sufficiently low that I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goal:
fixes #508
fixes #535
TODO:
import 'ses/lockdown';is allowedtest:xsto ci jobfeat(ava-xs): skip module-shimstuffAfter this PR at some point:
xsnapandava-xsfromagoric-sdk(IOU an issue)