Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement portal screenshot creation #142

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Implement portal screenshot creation #142

wants to merge 31 commits into from

Conversation

TornaxO7
Copy link
Collaborator

@TornaxO7 TornaxO7 commented Apr 4, 2024

No description provided.

@TornaxO7 TornaxO7 linked an issue Apr 4, 2024 that may be closed by this pull request
X11: backend::create_screenshots creates blank screenshots #91
Open
@TornaxO7 TornaxO7 marked this pull request as draft April 4, 2024 18:38
@TornaxO7 TornaxO7 marked this pull request as ready for review April 4, 2024 20:46
@TornaxO7 TornaxO7 changed the title Implement dbus backend Implement portal screenshot creation Apr 4, 2024
@TornaxO7
Copy link
Collaborator Author

TornaxO7 commented Apr 4, 2024 •
edited
Loading

Why is the CI stuck?
monkaW

@TornaxO7 TornaxO7 requested a review from eneoli April 4, 2024 21:06
@TornaxO7
Merge branch 'main' of github.com:eneoli/flakeshot into 91-x11-backen…
ef7e875 
…dcreate_screenshots-creates-blank-screenshots
eneoli
eneoli reviewed May 21, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
eneoli
eneoli reviewed May 21, 2024
View reviewed changes
src/backend/x11/fallback.rs Outdated Show resolved Hide resolved
eneoli
eneoli reviewed May 21, 2024
View reviewed changes
src/backend/x11/fallback.rs Outdated Show resolved Hide resolved
eneoli
eneoli reviewed May 21, 2024
View reviewed changes
src/backend/x11/mod.rs Outdated Show resolved Hide resolved
eneoli
eneoli reviewed May 21, 2024
View reviewed changes
src/backend/x11/mod.rs Outdated Show resolved Hide resolved
eneoli
eneoli requested changes May 21, 2024
View reviewed changes
Copy link
Owner

@eneoli eneoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@TornaxO7
Copy link
Collaborator Author

hm... ok, after reading through your comments, I think that there has been a missunderstanding. I thought that we only want to use the portal if the user is on X11 and GNOME or KDE. Will fix it 👍

@TornaxO7 TornaxO7 marked this pull request as draft August 11, 2024 09:02
@TornaxO7 TornaxO7 marked this pull request as ready for review November 7, 2024 21:04
@TornaxO7 TornaxO7 requested a review from eneoli November 7, 2024 21:36
@TornaxO7
Copy link
Collaborator Author

TornaxO7 commented Nov 7, 2024 •
edited
Loading

Note: I only tested this on Xorg and it works for me (tested on KDE (with portals :D) and i3 with cargo run -- -l info gui)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eneoli eneoli Awaiting requested review from eneoli

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

X11: backend::create_screenshots creates blank screenshots
2 participants
@TornaxO7 @eneoli