Backend/x11 #22
Merged
Backend/x11 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneoli
reviewed
Nov 10, 2023
|
Regarding your async mention: We should provide an uniform interface. For example if implementing dbus we will also need to wait for some sort of callback. |
hm... isn't the code not readable enough? Aren't the variable names + function names explaining enough? |
Closed
eneoli
requested changes
Nov 13, 2023
TornaxO7
force-pushed
the
backend/x11
branch
from
30149da
to
c16d527
Compare
eneoli
requested changes
Nov 15, 2023
eneoli
approved these changes
Nov 15, 2023
eneoli
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the backend implementation for
X11.Closes #3
General information
I'm aware, that you need
asyncfor wayland. But that's not needed forxorgand we can still call this function in an async function.