ETL-240: Investigate in process hosting model in combination with 2 apps #32
Conversation
| <PropertyGroup> | ||
| <AspNetCoreHostingModel>OutOfProcess</AspNetCoreHostingModel> | ||
| </PropertyGroup> | ||
|
|
There was a problem hiding this comment.
In process hosting is default
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\Enigmatry.Entry.Blueprint.Infrastructure\Enigmatry.Entry.Blueprint.Infrastructure.csproj"/> | ||
| <ProjectReference Include="..\Enigmatry.Entry.Blueprint.Domain\Enigmatry.Entry.Blueprint.Domain.csproj"/> | ||
| <ProjectReference Include="..\enigmatry-entry-blueprint-app\Enigmatry.Entry.Blueprint.App.esproj" /> |
There was a problem hiding this comment.
This reference was added
| @@ -11,7 +11,7 @@ public static class SwaggerAuthenticationStartupExtensions | |||
| public static void AppUseSwaggerWithAzureAdAuth(this IApplicationBuilder app, IConfiguration configuration) | |||
| { | |||
| var aadOptions = configuration.GetSection(AuthenticationStartupExtensions.AzureAdSection).Get<MicrosoftIdentityOptions>()!; | |||
| app.UseEntrySwaggerWithOAuth2Client(aadOptions.ClientId!); | |||
| app.UseEntrySwaggerWithOAuth2Client(aadOptions.ClientId!, path: "/swagger"); | |||
| } | |||
There was a problem hiding this comment.
Swagger UI will now be hosted on /swagger, since /api will no longer be there.
| <ShouldRunBuildScript>false</ShouldRunBuildScript> | ||
| <!-- Folder where production build objects will be placed --> | ||
| <BuildOutputFolder>$(MSBuildProjectDirectory)\dist\</BuildOutputFolder> | ||
| <BuildCommand>npm run build -- --configuration production</BuildCommand> |
There was a problem hiding this comment.
This will automatically be called when the API project builds, because of the project reference.
There was a problem hiding this comment.
We usually develop FE in VS Code and BE (API) in VS. This is convenient for CI/CD since it's gonna simplify steps needed for build, but will slow down API development? Can we say that this is for release builds only?
There was a problem hiding this comment.
The ShouldRunBuildScript parameter on line 6 is set to false, which prevents running build from Visual Studio. However, the command on line 9 is still triggered when the dotnet publish command is used (for example, in a CI/CD scenario). (Yes, it took me some time to figure that out)
| } | ||
| }, | ||
| "Enigmatry.Entry.Blueprint.Api": { | ||
| "commandName": "Project", | ||
| "launchBrowser": false, | ||
| "applicationUrl": "http://localhost:5441/", | ||
| "environmentVariables": { | ||
| "ASPNETCORE_ENVIRONMENT": "Development" | ||
| "ASPNETCORE_ENVIRONMENT": "Development", | ||
| "ASPNETCORE_HOSTINGSTARTUPASSEMBLIES": "Microsoft.AspNetCore.SpaProxy" |
There was a problem hiding this comment.
Do we need this on app service, or it's needed only in local dev?
| <ItemGroup> | ||
| <ParameterValue Include="SQLDB Connection String"> |
There was a problem hiding this comment.
We are going to deploy only app.proj? This might require a bit of work to combine publish profiles of angular with the api. Not sure if we are goging to have naming collisions (same properties, different values).
No description provided.