BP-1166: Configure integration tests to capture log statements from t… #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he production code (in WebApplication factory use Server.PreserveExecutionContext = true)
zsrdjan
commented
Jul 16, 2024
| _isUserAuthenticated = isUserAuthenticated; | ||
|
|
||
| // needed so that log statements from the Api appear in the test console runner | ||
| Server.PreserveExecutionContext = true; |
There was a problem hiding this comment.
This is needed for the log statements of the production code to appear in the tests.
| restrictedToMinimumLevel: LogEventLevel.Warning, | ||
| formatProvider: CultureInfo.InvariantCulture, | ||
| outputTemplate: "[{Timestamp:HH:mm:ss} {Level:u3}] [{SourceContext}] {Message:lj}{NewLine}{Exception}"); | ||
| loggerConfiguration.ConfigureSerilogForIntegrationTests(); |
There was a problem hiding this comment.
Move to shared extension class so that same settings can be used in the scheduler.
| // this allows serilog log statements to appear in the test console runner | ||
| // e.g. database sql queries (issued by DbContext) can be observed this way in the test | ||
| loggerConfiguration.WriteTo.Console( | ||
| LogEventLevel.Information, |
There was a problem hiding this comment.
With Information log level we can see what is happening in our code. However some noise appears, which makes reading logs harder. The noise is supressed below.
edekoning
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he production code (in WebApplication factory use Server.PreserveExecutionContext = true)