Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): use embedding dimensions instead of model default dimensions for nearest neighbor search (Fix #49 ) #50

Merged

Conversation

hydrosquall
Copy link
Contributor

@hydrosquall hydrosquall commented Jul 13, 2024

Motivation

Changes

  • Pass through embedding dimensions when available from frontend to Explore page. ( datasets/$DATASET/explore/$SCOPE, where $DATASET and $SCOPE are variables
  • My IDE removed trailing whitespace from a bunch of lines. You can review this diff ignoring those parts using this link ( https://github.com/enjalot/latent-scope/pull/50/files?diff=split&w=1 ), or I can look into putting the trailing whitespaces back.

Testing

image

For new users: here's the nearest neighbor search box

  • Tested the nearest neighbor search box using a dataset of 1000 points and vector size 256 following the local development instructions
  • Noticed an unrelated issue (search errors if your dataset has fewer than 150 points), but that seems like a separate fix (the frontend could add a UI to let the user pass in a hard coded nearest neighbor count, or default to a fraction of the total row count).

@enjalot
Copy link
Owner

enjalot commented Jul 23, 2024

thank you, including this in 0.4.0!

@hydrosquall hydrosquall deleted the cameron.yick/fix-nearest-neighbor-search branch July 24, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Nearest neighbor search errors if using non-default feature size for a text embedding model
2 participants