Change namespace to EnricoSada.MSBuild et. al. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with the MSBuild library. Remove all unused MSBuild code. Make the FileUtilities class internal (it had no public members).
|
No longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the library exposes a modified edition of MSBuild's solution reader under the name
Microsoft.Build.Construction.SolutionFile, we cannot use it from a project that uses the officialMicrosoft.BuildMSBuild library at the same time.For this reason, this PR renames the library's public types' namespace to
EnricoSada.MSBuild. This is a breaking change but very simple to fix. The version number was also bumped to0.4.0.Furthermore, this PR removes the parts of MSBuild's source code that is unused (that's why thousands of files changed), adds NuGet metadata to the project, slightly optimizes
build.projand clarifies the README.Because this PR blocks the ongoing progress of ionide/proj-info#87's fix, it would be greatly appreciated if it was expeditiously merged.