Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perseus section references #32

Closed
atomrab opened this issue Jul 5, 2014 · 3 comments
Closed

Perseus section references #32

atomrab opened this issue Jul 5, 2014 · 3 comments

Comments

@atomrab
Copy link

atomrab commented Jul 5, 2014

I was certain I'd seen a version of HestiaVis where the text chunks were linked to the appropriate Perseus sections. The scripting has clearly been adapted -- in Eric's version, the link is just to the Perseus text citation, but I can see that the current Perseus link includes both book and chapter. But now, in both the OU version and the version on your repo, we're back to all links leading to the first section of the first book in Perseus, which is not that useful. It would be much better to go directly to the same section -- and if this scripting was already done, not too difficult, right? Or am I misremembering?

@enridaga
Copy link
Owner

enridaga commented Jul 6, 2014

We never linked to perseus sections. After discussions here [1] I
implemented the link to chapters [2] from the reading view. Link to
sections cannot be done because sections are not there.

Currently, the "View on Perseus" link from the reading view points to the
book+chapter page [1].
The same link on the place details view points to the first book first
chapter. The reason is that in the page details view we are "outside" the
reading flow so I cannot know where to point to.

Did I misunderstood anything?

[1] ekansa/gap2#23
[2] #20
[3] http://enridaga.github.io/gapvis/gap2/#book/1/read/247/604
[4] http://enridaga.github.io/gapvis/gap2/#book/1/place/604

Enrico Daga

http://www.enridaga.net
skype: enri-pan

On 5 July 2014 14:39, atomrab notifications@github.com wrote:

I was certain I'd seen a version of HestiaVis where the text chunks were
linked to the appropriate Perseus sections. The scripting has clearly been
adapted -- in Eric's version, the link is just to the Perseus text
citation, but I can see that the current Perseus link includes both book
and chapter. But now, in both the OU version and the version on your repo,
we're back to all links leading to the first section of the first book in
Perseus, which is not that useful. It would be much better to go directly
to the same section -- and if this scripting was already done, not too
difficult, right? Or am I misremembering?


Reply to this email directly or view it on GitHub
#32.

@atomrab
Copy link
Author

atomrab commented Jul 7, 2014

Sorry, by "sections" I meant "chapters" -- we're on the same page here.

But there's some funny behavior happening with the links as they are. I was trying to get from a Hestia reading (not place details, of course) page to the corresponding Perseus page, and I was always getting 1.1. In attempting to replicate the problem, I've discovered that in both Chrome and Firefox right now, the link will work for the first page you load, or after you've reloaded a page -- but if you load 1.1 and then click on the bottom section navigation to the next page or any subsequent page without reloading, the Perseus link still sends you to 1.1.

This is the same issue that messed with the Hypothesis annotation platform. The script wants to see a change to a new HTML page, but it's getting only internal javascript changes, so it's ignoring them (at least that's what I think is happening, from a lay perspective).

Try it out: load to 1.1, then click on the bottom to 1.4, then click on the Perseus link. I'm still getting 1.1 in Perseus.

@enridaga
Copy link
Owner

enridaga commented Jul 7, 2014

Hi Adam. Got it now. The problem is that the link is generated on reading
view creation. And does not update on page change. This is a bug :(


enridaga

On 7 July 2014 01:34, atomrab notifications@github.com wrote:

Sorry, by "sections" I meant "chapters" -- we're on the same page here.

But there's some funny behavior happening with the links as they are. I
was trying to get from a Hestia reading (not place details, of course) page
to the corresponding Perseus page, and I was always getting 1.1. In
attempting to replicate the problem, I've discovered that in both Chrome
and Firefox right now, the link will work for the first page you load, or
after you've reloaded a page -- but if you load 1.1 and then click on the
bottom section navigation to the next page or any subsequent page without
reloading, the Perseus link still sends you to 1.1.

This is the same issue that messed with the Hypothesis annotation
platform. The script wants to see a change to a new HTML page, but it's
getting only internal javascript changes, so it's ignoring them (at least
that's what I think is happening, from a lay perspective).

Try it out: load to 1.1, then click on the bottom to 1.4, then click on
the Perseus link. I'm still getting 1.1 in Perseus.


Reply to this email directly or view it on GitHub
#32 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants